{"id":3202,"date":"2014-03-20T02:40:32","date_gmt":"2014-03-20T02:40:32","guid":{"rendered":"https:\/\/unknownerror.org\/index.php\/2014\/03\/20\/why-wont-my-phpmailer-script-work-to-get-save-files-collection-of-common-programming-errors\/"},"modified":"2014-03-20T02:40:32","modified_gmt":"2014-03-20T02:40:32","slug":"why-wont-my-phpmailer-script-work-to-get-save-files-collection-of-common-programming-errors","status":"publish","type":"post","link":"https:\/\/unknownerror.org\/index.php\/2014\/03\/20\/why-wont-my-phpmailer-script-work-to-get-save-files-collection-of-common-programming-errors\/","title":{"rendered":"Why wont my PHPmailer script work to get \/ save files?-Collection of common programming errors"},"content":{"rendered":"

First warning: You’re chmodding the uploads<\/code> directory itself. Unless the directory is owned by your webserver’s user ID, you’ll get the permission denied error – you cannot chmod something that does not belong to you.<\/p>\n

Second and Third warning: Your array keys in the $_FILES<\/code> array are incorrect. They should be<\/p>\n

while(list($key,$value) = each($_FILES['images']['name']))\n<\/code><\/pre>\n
note the quotes – without the quotes, PHP assumes they’re constants that were created via define()<\/code>. If there’s no constant by that name, PHP polite will treat them as strings of the same name, but issues the warning.<\/p>\n
Fourth warning: You’re misusing each()<\/code>. Instead, just have:<\/p>\n
foreach($_FILES['images']['name'] as $key => $value) {\n<\/code><\/pre>\n
Fifth warning: The only place you assign a value to $success<\/code> is within the if()<\/code> that does the image copy, when the file copy succeeds. Since your code is broken, the copy never takes place, so $success<\/code> is never defined. To fix, put a<\/p>\n
$success = false;\n<\/code><\/pre>\n
somewhere at the top of your file, so it’s defined with a default value.<\/p>\n
Beyond that, don’t use copy()<\/code> on uploaded files. There’s security issues involved with PHP and file uploads on shared servers. Use move_uploaded_file()<\/code> instead. This will be a far cheaper operation as well, since moving a file within a single filesystem is near instantaneous, while copy()<\/code> actually duplicates the file – on large files this gets expensive (time + cpu + disk space) very quickly.<\/p>\n
comment followup:<\/p>\n
It does matter how you name the input fields, as that’ll determine how things show up in the files array.<\/p>\n
If you go with the file1<\/code>, file2<\/code>, etc… option, you end up with:<\/p>\n
$_FILES = array(\n    'file1' => array('name' => ..., 'size' => ..., etc...),\n    'file2' => array('name' => ..., 'size' => ..., etc...),\n    etc...\n)\n<\/code><\/pre>\n
If you do files[]<\/code>, you end up with:<\/p>\n
$_FILES = array (\n   'files' => array\n        'name' => array(\n            0 = 'name of first file',\n            1 = 'name of second file',\n            ...\n        'size' => array(\n            0 = 'size of first file'\n            1 = 'name of second file'\n         etc...\n<\/code><\/pre>\n
A major structural difference. I have no idea why such a moronic difference was allowed to go into production, but since this is core PHP functionality, changing it to be more logically consistent is basically impossible.<\/p>\n","protected":false},"excerpt":{"rendered":"
First warning: You’re chmodding the uploads directory itself. Unless the directory is owned by your webserver’s user ID, you’ll get the permission denied error – you cannot chmod something that does not belong to you. Second and Third warning: Your array keys in the $_FILES array are incorrect. They should be while(list($key,$value) = each($_FILES[‘images’][‘name’])) note […]<\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[1],"tags":[],"class_list":["post-3202","post","type-post","status-publish","format-standard","hentry","category-uncategorized"],"_links":{"self":[{"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/posts\/3202","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/comments?post=3202"}],"version-history":[{"count":0,"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/posts\/3202\/revisions"}],"wp:attachment":[{"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/media?parent=3202"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/categories?post=3202"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/unknownerror.org\/index.php\/wp-json\/wp\/v2\/tags?post=3202"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}